Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: Use the Status API #27

Closed
DilumAluthge opened this issue Oct 17, 2019 · 1 comment · Fixed by #152
Closed

Idea: Use the Status API #27

DilumAluthge opened this issue Oct 17, 2019 · 1 comment · Fixed by #152
Assignees

Comments

@DilumAluthge
Copy link
Member

DilumAluthge commented Oct 17, 2019

The pull request build needs to save state, because the cron build will later retrieve that state. The state consists of:

  1. Did this PR meet all of the automerge guidelines? Yes or No.
  2. If it met all of the automerge guidelines, what was the SHA of the PR's head branch at the time of approval?

Currently, we use pull request reviews as a way of saving this state. But I think that it would be more robust to use either the Statuses API or the Checks API in order to save and retrieve this state.

The GitHub API reference says:

The Checks API functionality is available exclusively to your GitHub Apps.

So I think we should use the Statuses API instead.

@DilumAluthge
Copy link
Member Author

I am eternally grateful to the authors of GitHub.jl: https://github.com/JuliaWeb/GitHub.jl/blob/master/src/repositories/statuses.jl

@DilumAluthge DilumAluthge self-assigned this Oct 19, 2019
SebastianM-C referenced this issue in SebastianM-C/RegistryCI.jl Sep 15, 2021
Co-authored-by: SebastianM-C <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant