Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tag ignored second (correcty) register() call #3

Closed
dlfivefifty opened this issue Apr 23, 2019 · 3 comments · Fixed by JuliaRegistries/Registrator.jl#109
Closed

Tag ignored second (correcty) register() call #3

dlfivefifty opened this issue Apr 23, 2019 · 3 comments · Fixed by JuliaRegistries/Registrator.jl#109

Comments

@dlfivefifty
Copy link

This tag

https://github.com/JuliaApproximation/DomainSets.jl/releases/tag/v0.0.2

was put on the wrong commit. The actual release

JuliaRegistries/General#220

was attached to a second call to register() associated with a different commit.
@christopher-dG
Copy link
Member

This is more of a Registrator bug, all TagBot does is read the commit hash that's mentioned in the PR body. Registrator however does not update the hash when it updates itself.

@dlfivefifty
Copy link
Author

OK I'll create a cross-ref issue.

This was referenced Apr 23, 2019
Closed
Closed
@christopher-dG christopher-dG mentioned this issue Apr 25, 2019
Merged
@christopher-dG
Copy link
Member

Looks like this will no longer be an issue as soon as the new Registrator version is deployed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update PR body when it already exists
2 participants
@dlfivefifty @christopher-dG