Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Look for commit SHA from tree SHA in all branches #74

Merged
merged 1 commit into from
Feb 27, 2020
Merged

Conversation

christopher-dG
Copy link
Member

@christopher-dG christopher-dG commented Feb 26, 2020

Fixes #73 (regression caused by #64)

If we don't find the commit in the default branch, check all the other ones too.

In the uncommon case of release commits not on the default branch, this requires up to 2N API calls where N Is the number of branches. It's a lot worse than the old Git CLI method, but I don't think we'll run into problems in practice.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TagBot does not work when release commit is not in master branch
1 participant