TagBot does not work when release commit is not in master branch

[tkf]

I noticed that a release I made via JuliaFolds/Transducers.jl#233 is not tagged by TagBot. It's been failing with

No matching commit was found for version v0.4.20 (c4f4cbdb7023e09acd0faebca628d386f1aaab98)

e.g. https://github.com/tkf/Transducers.jl/actions/runs/45228286

However, as you can see in JuliaRegistries/General#10043, the related commit is bf3a4db8ec49754e0a841db90e95a16d635a8667. I'm not sure where c4f4cbdb7023e09acd0faebca628d386f1aaab98 is comming from. It does not exist in the repository JuliaFolds/Transducers.jl@c4f4cbd (shows 404).

I used register(branch=release) when invoking JuliaRegistrator. Can it be relevant?

[tkf]

Another example:
tkf/BenchmarkCI.jl#42
JuliaRegistries/General#10096
https://github.com/tkf/BenchmarkCI.jl/actions/runs/45227753

[tkf]

I tried running TagBot 1.6.1 and 1.6.0 but it didn't work: JuliaFolds/Transducers.jl#234

It's strange because I think I made releases with those TagBot versions:
https://github.com/tkf/Transducers.jl/releases/tag/v0.4.19
https://github.com/tkf/Transducers.jl/releases/tag/v0.4.18

[tkf]

TagBot successfully tagged the release when I pushed the release commit to the master branch:

https://github.com/tkf/Transducers.jl/releases/tag/v0.4.20
https://github.com/tkf/BenchmarkCI.jl/releases/tag/v0.1.1

Can TagBot pull all git references (branches and tags) when looking for the release commit?

[christopher-dG]

Ahhhhhh this is a side effect of #64 that did not occur to me. Before that PR, we used a Git command to view all commits on all branches and look for one that had the given tree SHA (c4f4cbdb7023e09acd0faebca628d386f1aaab98 in your case). I don't think we can reasonably replicate the correct behaviour with the API, so part of that PR will have to get reverted. Thanks for reporting! I'll take care of it tonight.

[tkf]

I see. Thanks a lot for quickly looking into it!

[christopher-dG]

Oh yeah, I meant to mention about the "it used to work with other versions" thing:

Currently the version of TagBot that you use doesn't really matter, you still get the tagbot:1 Docker image which is constantly updated with each release, so you're always running the latest code even if you don't want to. This will no longer be the case when #69 is merged (for future versions, at least).

[tkf]

Ah, I see. Thanks for the explanation and the fix!