Merge pull request #153 from JuliaRobotics/21Q3/depr/setpointpartial

api instead setPointPartial!
JuliaRobotics · Aug 23, 2021 · cb410e5 · cb410e5
2 parents 112adc6 + 1554650
commit cb410e5
Show file tree

Hide file tree

Showing 3 changed files with 16 additions and 8 deletions.
diff --git a/src/Deprecated.jl b/src/Deprecated.jl
@@ -4,6 +4,14 @@
 ## Remove below before v0.6
 ## ======================================================================================================
 
+@deprecate setPointsManiPartial!( Mdest::AbstractManifold, 
+                                  dest, 
+                                  Msrc::AbstractManifold, 
+                                  src, 
+                                  partial::AbstractVector{<:Integer},
+                                  asPartial::Bool=true ) setPointPartial!( Mdest, dest, Msrc, src, partial, asPartial )
+
+
 export productbelief
 
 """

diff --git a/src/Interface.jl b/src/Interface.jl
@@ -5,7 +5,7 @@ import Manifolds: identity_element
 
 export makeCoordsFromPoint, makePointFromCoords, getNumberCoords
 export identity_element
-export setPointsManiPartial!, setPointsMani!
+export setPointPartial!, setPointsMani!
 export replace
 
 # Deprecate in favor of TranslationGroup instead, also type piracy
@@ -69,12 +69,12 @@ end
 
 
 # asPartial=true indicates that src coords are smaller than dest coords, and false implying src has dummy values in placeholder dimensions
-function setPointsManiPartial!( Mdest::AbstractManifold, 
-                                dest, 
-                                Msrc::AbstractManifold, 
-                                src, 
-                                partial::AbstractVector{<:Integer},
-                                asPartial::Bool=true )
+function setPointPartial!(Mdest::AbstractManifold, 
+                          dest, 
+                          Msrc::AbstractManifold, 
+                          src, 
+                          partial::AbstractVector{<:Integer},
+                          asPartial::Bool=true )
   #
 
   dest_ = AMP.makeCoordsFromPoint(Mdest,dest)

diff --git a/src/services/ManifoldKernelDensity.jl b/src/services/ManifoldKernelDensity.jl
@@ -182,7 +182,7 @@ function antimarginal(newM::AbstractManifold,
   pts = getPoints(mkd, false)
   nPts = Vector{typeof(u0)}(undef, length(pts))
   for (i,pt) in enumerate(pts)
-    nPts[i] = setPointsManiPartial!(newM, deepcopy(u0), mkd.manifold, pt, newpartial)
+    nPts[i] = setPointPartial!(newM, deepcopy(u0), mkd.manifold, pt, newpartial)
   end
 
   # also update metadata elements