Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better testing for product of only marginals #119

Merged
merged 26 commits into from
Jul 27, 2021
Merged

Conversation

dehann
Copy link
Member

@dehann dehann commented Jul 21, 2021

No description provided.

@dehann dehann added this to the v0.4.9 milestone Jul 21, 2021
@dehann dehann added enhancement New feature or request partials testing labels Jul 21, 2021
@dehann dehann self-assigned this Jul 21, 2021
@codecov-commenter
Copy link

codecov-commenter commented Jul 21, 2021

Codecov Report

Merging #119 (f53d09a) into master (e0e6444) will decrease coverage by 6.62%.
The diff coverage is 57.14%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #119      +/-   ##
==========================================
- Coverage   46.08%   39.46%   -6.63%     
==========================================
  Files          16       16              
  Lines         601      603       +2     
==========================================
- Hits          277      238      -39     
- Misses        324      365      +41     
Impacted Files Coverage Δ
src/ApproxManifoldProducts.jl 100.00% <ø> (ø)
src/Deprecated.jl 0.00% <ø> (ø)
src/CommonUtils.jl 41.66% <50.00%> (+24.27%) ⬆️
src/API.jl 73.80% <100.00%> (+16.66%) ⬆️
src/KernelHilbertEmbeddings.jl 0.00% <0.00%> (-100.00%) ⬇️
src/services/ManifoldKernelDensity.jl 30.58% <0.00%> (-38.83%) ⬇️
src/Legacy.jl 55.73% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0e6444...f53d09a. Read the comment docs.

@dehann dehann modified the milestones: v0.4.9, v0.4.10 Jul 26, 2021
@dehann dehann marked this pull request as ready for review July 27, 2021 20:44
@dehann
Copy link
Member Author

dehann commented Jul 27, 2021

Think Actions is caching the same test over and over again, So will have to do this in a new PR to find out what is going on with the NaN. Note that I am not seeing the same NaN issue when I test locally. Weird.

@dehann dehann merged commit d4bc643 into master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants