Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api instead setPointPartial! #153

Merged
merged 4 commits into from
Aug 23, 2021
Merged

api instead setPointPartial! #153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
21c4a9b
api instead setPointPartial!
dehann Aug 23, 2021
64c2e08
fix depr
dehann Aug 23, 2021
b3b7086
fix depr
dehann Aug 23, 2021
1554650
fix
dehann Aug 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/Deprecated.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,14 @@
## Remove below before v0.6
## ======================================================================================================

@deprecate setPointsManiPartial!( Mdest::AbstractManifold,
dest,
Msrc::AbstractManifold,
src,
partial::AbstractVector{<:Integer},
asPartial::Bool=true ) setPointPartial!( Mdest, dest, Msrc, src, partial, asPartial )


export productbelief

"""
Expand Down
14 changes: 7 additions & 7 deletions src/Interface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ import Manifolds: identity_element

export makeCoordsFromPoint, makePointFromCoords, getNumberCoords
export identity_element
export setPointsManiPartial!, setPointsMani!
export setPointPartial!, setPointsMani!
export replace

# Deprecate in favor of TranslationGroup instead, also type piracy
Expand Down Expand Up @@ -69,12 +69,12 @@ end


# asPartial=true indicates that src coords are smaller than dest coords, and false implying src has dummy values in placeholder dimensions
function setPointsManiPartial!( Mdest::AbstractManifold,
dest,
Msrc::AbstractManifold,
src,
partial::AbstractVector{<:Integer},
asPartial::Bool=true )
function setPointPartial!(Mdest::AbstractManifold,
dest,
Msrc::AbstractManifold,
src,
partial::AbstractVector{<:Integer},
asPartial::Bool=true )
#

dest_ = AMP.makeCoordsFromPoint(Mdest,dest)
Expand Down
2 changes: 1 addition & 1 deletion src/services/ManifoldKernelDensity.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ function antimarginal(newM::AbstractManifold,
pts = getPoints(mkd, false)
nPts = Vector{typeof(u0)}(undef, length(pts))
for (i,pt) in enumerate(pts)
nPts[i] = setPointsManiPartial!(newM, deepcopy(u0), mkd.manifold, pt, newpartial)
nPts[i] = setPointPartial!(newM, deepcopy(u0), mkd.manifold, pt, newpartial)
end

# also update metadata elements
Expand Down