Fix #32, GeometryTypes vs GeometryBasics #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gjk` call needs qualification to avoid clash with method in `GeometryTypes`.
Restrict compatibility with MeshIO due to its switch from GeometryTypes to GeometryBasics, which is missing several needed pieces.
Restricted Julia compatibility to allow hyphen compatibility range for MeshIO. Version bump so users of older Julia versions can still use the package.
Allow failures with versions of Julia that do not support version ranges for compatibility.
|
Thanks! Looks like TravisCI has cut me off, so I'll switch over to github actions after this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restricted MeshIO compatibility to <= 0.3.2, edited README to add necessary qualification on call.