Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for "Optim" to "1.0" #330

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 6, 2020

This pull request changes the compat entry for the Optim package from 0.19, 0.20, 0.21, 0.22 to 0.19, 0.20, 0.21, 0.22, 1.0.

This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry. It is your responsibility to make sure that your package tests pass before you merge this pull request.

@codecov-commenter
Copy link

codecov-commenter commented Sep 6, 2020

Codecov Report

Merging #330 into master will increase coverage by 2.27%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #330      +/-   ##
==========================================
+ Coverage   15.19%   17.46%   +2.27%     
==========================================
  Files          43       43              
  Lines        2145     2204      +59     
==========================================
+ Hits          326      385      +59     
  Misses       1819     1819              
Impacted Files Coverage Δ
src/RoME.jl 100.00% <0.00%> (ø)
src/RobotUtils.jl 4.78% <0.00%> (+0.48%) ⬆️
src/factors/VelPose2D.jl 93.33% <0.00%> (+1.02%) ⬆️
src/Deprecated.jl 10.25% <0.00%> (+1.46%) ⬆️
src/CanonicalGraphs.jl 37.34% <0.00%> (+1.54%) ⬆️
src/factors/VelPoint2D.jl 65.21% <0.00%> (+1.58%) ⬆️
src/factors/Pose3Pose3.jl 91.66% <0.00%> (+1.66%) ⬆️
src/factors/DynPoint2D.jl 35.29% <0.00%> (+1.96%) ⬆️
src/OdometryUtils.jl 46.42% <0.00%> (+1.98%) ⬆️
src/factors/Range2D.jl 26.47% <0.00%> (+2.22%) ⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5520c4...bda8d6d. Read the comment docs.

@dehann dehann merged commit ad7be22 into master Sep 6, 2020
@dehann dehann added this to the v0.9.1 milestone Sep 6, 2020
@dehann dehann deleted the compathelper/new_version/2020-09-06-01-02-30-793-817014096 branch August 4, 2021 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants