Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

standardize old ScalarFields test code #517

Merged
merged 8 commits into from
Oct 6, 2021
Merged

Conversation

dehann
Copy link
Member

@dehann dehann commented Oct 6, 2021

See ongoing error description at: #518 (comment)

@dehann dehann added this to the v0.16.0 milestone Oct 6, 2021
@dehann dehann self-assigned this Oct 6, 2021
@dehann dehann changed the title wip, standardize old ScalarFields test code standardize old ScalarFields test code Oct 6, 2021
@codecov
Copy link

codecov bot commented Oct 6, 2021

Codecov Report

Merging #517 (489403e) into master (96aa6c3) will increase coverage by 1.90%.
The diff coverage is 2.56%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #517      +/-   ##
=========================================
+ Coverage    1.16%   3.07%   +1.90%     
=========================================
  Files          47      49       +2     
  Lines        1978    2019      +41     
=========================================
+ Hits           23      62      +39     
- Misses       1955    1957       +2     
Impacted Files Coverage Δ
src/services/RequiresImages.jl 0.00% <0.00%> (ø)
src/services/ScalarFields.jl 0.00% <0.00%> (ø)
src/RoME.jl 100.00% <100.00%> (ø)
src/TemporaryFunctionality.jl 10.52% <0.00%> (+10.52%) ⬆️
src/factors/Point2D.jl 23.07% <0.00%> (+23.07%) ⬆️
src/factors/PartialPose3.jl 38.57% <0.00%> (+24.07%) ⬆️
src/factors/Pose3Pose3.jl 59.09% <0.00%> (+59.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf721e3...489403e. Read the comment docs.

@dehann dehann marked this pull request as ready for review October 6, 2021 15:38
@dehann dehann merged commit 36014ea into master Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant