Various 0.6 fixes #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
approved these changes
Jan 16, 2017
tkelman
reviewed
Jan 17, 2017
| d = ones(T,2) ; @test PDiagMat(d,d).inv_diag == PDiagMat(d).inv_diag | ||
| x = one(T) ; @test ScalMat(2,x,x).inv_value == ScalMat(2,x).inv_value | ||
| #for Julia v0.3, do not test sparse matrices with Float32 (see issue #14076) | ||
| (T == Float64 || VERSION >= v"0.4.2") && (s = speye(T,2,2) ; @test PDSparseMat(s,cholfact(s)).mat == PDSparseMat(s).mat == PDSparseMat(cholfact(s)).mat) |
There was a problem hiding this comment.
why did you delete this test?
There was a problem hiding this comment.
It is not relevant anymore. Nobody uses Julia < 0.4.2.
There was a problem hiding this comment.
Either you're reading this backwards or I am - this was a test that only ran on new enough julia. So it should still run.
There was a problem hiding this comment.
You are right. I got it backwards. I'll add it back.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nothing that should break anything