Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Equational theories require symmetric rules #20

Closed
jpfairbanks opened this issue Mar 4, 2021 · 3 comments
Closed

Equational theories require symmetric rules #20

jpfairbanks opened this issue Mar 4, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@jpfairbanks
Copy link

When using Metatheory for equational reasoning, we need to add both directions of all the axioms in the theory to the rewriting system. Would \iff be a good symbol for denoting a symmetric rule? ModelingToolkit uses ~ as an equation operator so that is another choice.
@0x0f0f0f
Copy link
Member

0x0f0f0f commented Mar 5, 2021

Added in 4580e9a

Symmetric rules now use == operator. Please let me know if they work as expected. I haven't updated tests. You could PR editing test/test_cat.jl if you want.

@0x0f0f0f
Copy link
Member

0x0f0f0f commented Mar 5, 2021

Fixed bug in latest commit. Should work now @jpfairbanks

@0x0f0f0f
Copy link
Member

0x0f0f0f commented Mar 5, 2021

Added tests with calculational/equational logic. Can close

https://github.com/0x0f0f0f/Metatheory.jl/blob/master/test/test_calculational_logic.jl

@0x0f0f0f 0x0f0f0f closed this as completed Mar 5, 2021
@0x0f0f0f 0x0f0f0f added the enhancement New feature or request label Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpfairbanks @0x0f0f0f