Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme doesnot work :( #42

Closed
aveekbhat opened this issue Jan 26, 2022 · 8 comments
Closed

Dark theme doesnot work :( #42

aveekbhat opened this issue Jan 26, 2022 · 8 comments
Milestone

Comments

@aveekbhat
Copy link

This is how the dark theme looks like

image

here is how the Google keyboard looks like
image

@Julow Julow added this to the 1.12.0 milestone Jan 26, 2022
@Julow
Copy link
Owner

Julow commented Jan 26, 2022

Did you use the "Theme" option in the settings ? Tap the "Conf" symbol on the bottom-right of the "Alt" key and scroll to the bottom.

The app doesn't work well with the system theme and I'd rather fix that for the next release.

@aveekbhat
Copy link
Author

Did you use the "Theme" option in the settings ? Tap the "Conf" symbol on the bottom-right of the "Alt" key and scroll to the bottom.
yes i did exactly that but it didnt work :( ... BTW .. my phone is in system dark mode

The app doesn't work well with the system theme and I'd rather fix that for the next release.

Thanks !!

@Julow
Copy link
Owner

Julow commented Jan 30, 2022

I couldn't reproduce the issue on the devices I have access to. I've attempted a fix (c9f7f2c) but I'll leave this open until you can try the next version.

@Yefita
Copy link

Yefita commented Feb 7, 2022

still doesn't work. at least on my phone
this is how dark mode look like
IMG_20220207_123225
and this is how black mode look like
IMG_20220207_123247
it happened on my xiaomi redmi note 7 with android 10(MIUI 12.5.1.0)

@ghost
Copy link

ghost commented Feb 12, 2022

Does the dark theme apply to the settings menu?

@Julow
Copy link
Owner

Julow commented Feb 13, 2022

Xiaomi phones have unusual dark theme mechanisms, I think I fixed the issue (adb7746).

The settings menu doesn't use dark theme yet, I'll leave this issue open until it does.

@Julow
Copy link
Owner

Julow commented Feb 27, 2022

Dark theme should now work fine. The settings will use dark theme for everyone now (4ee29f3), which I think is enough to close this.

@Julow Julow closed this as completed Feb 27, 2022
@aveekbhat
Copy link
Author

i can confirm it works fine now !! thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants