Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maybe it would be better to mock all used k8s APIs and verify our interactions with them instead of relying on minikube? I am not sure how reliable minikube is — for example on this line i have to wait a second before getting all jobs, because jobs are not deleted immediately. One second sleep works on my minikube installation, but will it work on others as well? It would be easier to just verify the interaction.
This will also allow us to test all error conditions that are not currently covered.
Also, as a side note, maybe DeleteJob should be renamed to either
Delete
orDeleteTask
because Job is a k8s abstraction, butDesirer
interface works with Diego abstractions.What do you think?