New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port is not defined under AnsibleModule and qfx default value mismatch #29

Closed

vnitinv opened this issue Jun 23, 2014 · 3 comments

Contributor

vnitinv commented Jun 23, 2014

https://github.com/Juniper/ansible-junos-stdlib/blob/master/library/junos_console_devicemode#L96

port as per description is Mandatory but cannot be seen under AnsibleModule.

qfx default value mimatch between none and node.
https://github.com/Juniper/ansible-junos-stdlib/blob/master/library/junos_console_devicemode#L76

https://github.com/Juniper/ansible-junos-stdlib/blob/master/library/junos_console_devicemode#L112

Contributor

jeremyschulman commented Jun 23, 2014

#L96 - is a documentation bug, port should be console in docstring.
#L76 - is a documentation bug, default should be None in docstring.

Contributor Author

vnitinv commented Jun 23, 2014

1st issue will be resolved if
#30
pull request is merged.

Contributor Author

vnitinv commented Jun 23, 2014

for 2nd issue:
#31

vnitinv closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment