Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup #277

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Rollup #277

wants to merge 36 commits into from

Conversation

aminya
Copy link

@aminya aminya commented May 28, 2020

We made it 😃 Fixes #144

  • This builds atom-ink using rollup.

Now it loads 2.6X faster

reduces the ink load time by 110ms + 20ms for julia-client

After Ink rollup and Katex movement

After Ink rollup without Katex movement

Without Ink rollup

  • Allows debugging using npm run debug

To achieve I made some changes to the code:

  • modernized the code to use import/exports.
  • decaffeinated ink.coffee.
  • fixed a couple of errors and typos here and there.
  • I removed the old abandoned underscore-plus in favor of actively maintained underscore. The new one is tree shakable, which gives more performance.
  • Moved Katex to julia-client

One difference: I used static import in ink.coffee (which bundles everything into one file). If you want I can change this to dynamic import (which makes use of Rollup's code splitting). I did not do this since I was not sure how these variables are used on the julia-client side, and using dynamic import may ruin the performance if these are called right away from the Julia client.

Registering

Similar to JunoLab/atom-indent-detective#23

Commit history is verbose so you can review it easily.

In sync with JunoLab/atom-julia-client#750

@aminya
Copy link
Author

aminya commented May 28, 2020

@pfitzseb Could you review this? If you have any questions we can have a skype call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve package load time
1 participant