Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Config field username check #817

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

VDubber
Copy link
Contributor

@VDubber VDubber commented Nov 8, 2022

Windows does not allow USERNAME env var to be set. This causes issues when a graph project is used in an on-prem scenario and a config field name username is used.

The changes here are to throw an exception when username is specified. allowUsername is a backwards compat option.

- Added new config field value `allowUsername` to support backwards compatibility
- updated docs to discourage use of `username`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants