Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Memgraph integration SDK CLI #941

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

matea16
Copy link

@matea16 matea16 commented Aug 4, 2023

Added integration for Memgraph related to the Starbase PR: JupiterOne/starbase#99

@matea16 matea16 requested a review from a team as a code owner August 4, 2023 08:02
## Installation

This command assumes you have three additional values stored in your local .env
file: NEO4J_URI NEO4J_USER NEO4J_PASSWORD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these .env value names correct? I think you've declared MEMGRAPH specific ones elsewhere.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right, I fixed the value names in the newest commit

getToTypeLabel,
} from './memgraphUtilities';

import * as memgraph from 'neo4j-driver';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does Memgraph use the same Javascript driver as Neo4j? If so, would we be able to share some of the same codebase with our existing Neo4j graph storage?

Copy link
Author

@matea16 matea16 Sep 21, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, Memgraph is compatible with Neo4j and uses the same JS driver so you can share some of the codebase. I separated everything to preserve the integrity of your code, but feel free to make the necessary changes

@adam-in-ict
Copy link
Contributor

Thanks so much for the contribution! I left a few comments. My biggest question is whether or not we can share some code with our existing Neo4j functions to make long term support easier.

Also, it looks like some checks might be failing due to formatting issues. We have an included command to update everything to our formatting standards if you run yarn format.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants