Skip to content

Commit

Permalink
don't set python exe to undefined
Browse files Browse the repository at this point in the history
Summary:
FindPythonInterp sets PYTHON_EXECUTABLE, we overrode it by setting an
empty var. add a comment to explain the unbalancedness of the conditional
branches.

Test Plan: pythoncairo is correctly found with cmake 3.10.2

Reviewers: davidedmundson, fvogt

Reviewed By: fvogt

Subscribers: fvogt, heikobecker, plasma-devel

Tags: #plasma

Differential Revision: https://phabricator.kde.org/D18309
  • Loading branch information
hsitter committed Jan 17, 2019
1 parent de20417 commit 51e27ec
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion cmake/FindPythonCairo.cmake
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
if(CMAKE_VERSION VERSION_LESS 3.12.0)
find_package(PythonInterp 3 REQUIRED)
set(PYTHON_EXECUTABLE "${Python3_EXECUTABLE}")
# PythonInterp sets PYTHON_EXECUTABLE
else()
find_package(Python3 COMPONENTS Interpreter REQUIRED)
set(PYTHON_EXECUTABLE "${Python3_EXECUTABLE}")
Expand Down

0 comments on commit 51e27ec

Please sign in to comment.