Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Split plugins to categories | 0.2.7] doesn't work on Windows OS #212

Closed
alexhx5 opened this issue Mar 4, 2017 · 6 comments
Closed

[Split plugins to categories | 0.2.7] doesn't work on Windows OS #212

alexhx5 opened this issue Mar 4, 2017 · 6 comments

Comments

@alexhx5
Copy link

alexhx5 commented Mar 4, 2017

It looks like [Split plugins to categories | 0.2.7] doesn't work on Windows OS
Can anybody else confirm this?

In this example, I installed the Clipboard plugin, but it didn't go up on the top. App restart didn't help

screenshot 935

@maximbaz
Copy link
Contributor

maximbaz commented Mar 4, 2017

Curious how could this functionality be OS-specific, but yes, it doesn't repro on Linux.

@alexhx5
Copy link
Author

alexhx5 commented Mar 4, 2017

@maximbaz that's what I was wondering. Well, maybe PR #208 didn't make it to the .exe of the 0.2.7 build, at all? Not sure what else could it be. @KELiON any thoughts? What does it looks like on MacOS for you?

@maximbaz
Copy link
Contributor

maximbaz commented Mar 4, 2017

That's relatively easy to check, open DevTools (main) from the tray icon, hit Ctrl+Shift+F to search in all files, enter categorize and hit Enter.

If that code made into your app, you will see this:

image

Also check if you see any errors in the console tab.

@alexhx5
Copy link
Author

alexhx5 commented Mar 4, 2017

@maximbaz there's no errors in the console. The categorize const is not there. So I guess, it didn't make it to the .exe after all

1

@maximbaz
Copy link
Contributor

maximbaz commented Mar 4, 2017

/cc @KELiON

@tiagoamaro
Copy link
Contributor

@maximbaz, after reading your comment, I wondered why my packaged 0.2.7 didn't have this feature as well (running on macOS). I just cloned the repo, ran yarn run package on latest master, and now I have all features described at the release changelog.

Probably, windows version (as macOS version) wasn't created on 0.2.7 commit as reported at https://github.com/KELiON/cerebro/releases/tag/0.2.7.

Comparing it's md5 hashes for the 0.2.7 version commit (https://github.com/KELiON/cerebro/tree/292d9c43c603d87106a9042cc86f7c23df0256d9), my packaged .dmg md5 hash is 78109b5b95f4647d71c8b57eb9dfe266, while the one on Github is cc5d484be452fdc164fef0030ada6d68.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants