Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark theme font color issue #269

Closed
2 tasks done
sepehr opened this issue Apr 5, 2017 · 6 comments
Closed
2 tasks done

Dark theme font color issue #269

sepehr opened this issue Apr 5, 2017 · 6 comments

Comments

@sepehr
Copy link

sepehr commented Apr 5, 2017

  • I am on the latest Cerebro.app version

  • I have searched the issues of this repo and believe that this is not a duplicate

  • OS version and name: macOS 10.12.4

  • Cerebro.app version: 0.2.7

  • Relevant information from devtools: N/A

Issue

When I enable the dark theme, the font color is not right:

cerebro dark theme font color issue

I restarted Cerebro, still no change.

@KELiON
Copy link
Collaborator

KELiON commented Apr 6, 2017

@sepehr can you please add a list of installed plugins? Looks like some plugin overrides some styles

@sepehr
Copy link
Author

sepehr commented Apr 7, 2017

@KELiON Here:

cerebro-base64
cerebro-clipboard
cerebro-devdocs
cerebro-emoj
cerebro-gif
cerebro-github
cerebro-hash
cerebro-imdb
cerebro-ip
cerebro-kill
cerebro-lipsum
cerebro-osx-eject
cerebro-osx-system
cerebro-reload
cerebro-rot13
cerebro-shell
cerebro-stackoverflow
cerebro-timestamp
cerebro-timezones
cerebro-weather
cerebro-wiki
convert-color

If that's the case, I think I need to go through the devtools and detect which plugin is causing this.

@KELiON
Copy link
Collaborator

KELiON commented Apr 7, 2017

@sepehr ok, I found! It is covert-color, I've opened an issue in the repo, so this one can be closed.

If you want to fix it now (and don't wait for author to fix this bug) you can uninstall this plugin and reload an app.

@KELiON KELiON closed this as completed Apr 7, 2017
@rafa-acioly
Copy link

rafa-acioly commented Apr 7, 2017

Hi guys, the problem was that I was using bulma css and I did not realize that the framework was overwriting the default style, sorry! I already publish a new version on npmjs

the commit fixing the problem

@KELiON
Copy link
Collaborator

KELiON commented Apr 7, 2017

@rafa-acioly it was fast! Thank you!:)

@sepehr
Copy link
Author

sepehr commented Apr 7, 2017

Thank you @KELiON and @rafa-acioly both for finding and fixing this.

@rafa-acioly BTW, I was used to the font family change, that was way nicer than the default font face.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants