Merge #3739 Fix auto-removal

KSP-CKAN · Dec 8, 2022 · 79a6618 · 79a6618
2 parents bb56dbe + 554c0b3
commit 79a6618
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,7 +12,7 @@ All notable changes to this project will be documented in this file.
 
 - [GUI] Remove duplicate Install changes for upgrades (#3706 by: HebaruSan; reviewed: techman83)
 - [GUI] Fix GUI freeze with non-empty changeset at startup (#3708 by: HebaruSan; reviewed: techman83)
-- [GUI] Use changeset tab for reinstall (#3726, #3728 by: HebaruSan; reviewed: techman83)
+- [GUI] Use changeset tab for reinstall (#3726, #3728, #3739 by: HebaruSan; reviewed: techman83)
 - [Core] Fix handling of empty builds.json file (#3733 by: HebaruSan; reviewed: DasSkelett)
 
 ### Internal

diff --git a/GUI/Main/MainChangeset.cs b/GUI/Main/MainChangeset.cs
@@ -40,7 +40,9 @@ private void Changeset_OnConfirmChanges(List<ModChange> changeset)
                     new KeyValuePair<List<ModChange>, RelationshipResolverOptions>(
                         changeset
                             // Only pass along user requested mods, so auto-installed can be determined
-                            .Where(ch => ch.Reasons.Any(r => r is SelectionReason.UserRequested))
+                            .Where(ch => ch.Reasons.Any(r => r is SelectionReason.UserRequested)
+                                // Include all removes and upgrades
+                                || ch.ChangeType != GUIModChangeType.Install)
                             .ToList(),
                         RelationshipResolver.DependsOnlyOpts()));
             }