Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix auto-removal #3739

Merged
merged 1 commit into from Dec 8, 2022
Merged

Fix auto-removal #3739

merged 1 commit into from Dec 8, 2022

Conversation

HebaruSan
Copy link
Member

Problem

  1. Install MiniAVC (or any other mod)
  2. Check the checkbox for auto-installed
  3. Click Apply changes
  4. The changeset tab appears and shows the mod being removed
  5. Click Continue
  6. The install flow does nothing

Cause

#3726 made it so that when you click to confirm a changeset, instead of recalculating the changeset from the mod grid as we did previously, it used the data from the same changeset object that the user just viewed and approved in the changeset tab. This allows us to use the changeset tab for changesets other than the one selected on the main mod list (such as reinstallation via the right click menu, which cannot otherwise be represented by the main mod list's checkboxes).

#3728 changed it to filter out non-user-requested changes. But this means auto-removals are filtered out of the changeset because their reason is not SelectionReason.UserRequested but rather SelectionReason.NoLongerUsed. They should be kept.

Changes

Now all non-install changes are passed from the changeset tab to the install flow. Only non-user-requested installs are filtered out.

Fixes #3738.

@HebaruSan HebaruSan added Bug Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request labels Dec 7, 2022
Copy link
Member

@techman83 techman83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense! 🎉

@HebaruSan HebaruSan merged commit 79a6618 into KSP-CKAN:master Dec 8, 2022
@HebaruSan HebaruSan deleted the fix/autoremove branch December 8, 2022 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] CKAN 1.31.3 Zero MiniAVC doesn't uninstall
2 participants