Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug: We write all files in text mode. #205

Closed
pjf opened this issue Oct 30, 2014 · 1 comment · Fixed by #206
Closed

Bug: We write all files in text mode. #205

pjf opened this issue Oct 30, 2014 · 1 comment · Fixed by #206
Assignees
@pjf
Labels
Bug Core (ckan.dll) Issues affecting the core part of CKAN

Comments

@pjf
Copy link
Member

pjf commented Oct 30, 2014

Holy smokes this is terrible. We should use binary mode for everything.

Spotted by @godarklight.
@pjf pjf added Bug ★★★ Core (ckan.dll) Issues affecting the core part of CKAN labels Oct 30, 2014
@pjf pjf self-assigned this Oct 30, 2014
@pjf pjf added In progress We're still working on this and removed ★★★ labels Oct 30, 2014
@pjf
Copy link
Member Author

pjf commented Oct 30, 2014

Have a working test. Fixing bug now.

pjf added a commit to pjf/CKAN that referenced this issue Oct 30, 2014
@pjf
Test case to show the presence of the text vs binary bug.
0297b27 
For KSP-CKAN#205.
pjf added a commit to pjf/CKAN that referenced this issue Oct 30, 2014
@pjf
Make sure we write all our files in binary mode.
ee84dbd 
- Supports transactions.
- Includes tests.
- Closes KSP-CKAN#205
@pjf pjf mentioned this issue Oct 30, 2014
Merged
@AlexanderDzhoganov AlexanderDzhoganov removed the In progress We're still working on this label Oct 30, 2014
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@pjf
Test case to show the presence of the text vs binary bug.
620dea7 
For KSP-CKAN#205.
RichardLake pushed a commit to RichardLake/CKAN that referenced this issue May 30, 2015
@pjf
Make sure we write all our files in binary mode.
34bbcff 
- Supports transactions.
- Includes tests.
- Closes KSP-CKAN#205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pjf pjf

Labels
Bug Core (ckan.dll) Issues affecting the core part of CKAN
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Always write files in binary mode. pjf/CKAN
2 participants
@pjf @AlexanderDzhoganov