Test case to show the presence of the text vs binary bug.

For KSP-CKAN#205.
pjf · Oct 30, 2014 · 0297b27 · 0297b27
1 parent 2422baf
commit 0297b27
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 1 deletion.
diff --git a/CKAN/CKAN/ModuleInstaller.cs b/CKAN/CKAN/ModuleInstaller.cs
@@ -726,7 +726,10 @@ public static List<InstallableFile> FindInstallableFiles(CkanModule module, stri
             }
         }
 
-        private void CopyZipEntry(ZipFile zipfile, ZipEntry entry, string fullPath, bool makeDirs)
+        /// <summary>
+        /// Copy the entry from the opened zipfile to the path specified.
+        /// </summary>
+        internal static void CopyZipEntry(ZipFile zipfile, ZipEntry entry, string fullPath, bool makeDirs)
         {
             if (entry.IsDirectory)
             {

diff --git a/CKAN/Tests/CKAN/ModuleInstaller.cs b/CKAN/Tests/CKAN/ModuleInstaller.cs
@@ -96,6 +96,32 @@ public void No_Installable_Files()
             }
         }
 
+        [Test()]
+        // GH #205, make sure we write in *binary*, not text.
+        public void BinaryNotText_205()
+        {
+            string dogezip = Tests.TestData.DogeCoinFlagZip();
+            ZipFile zipfile = new ZipFile(dogezip);
+
+            ZipEntry entry = zipfile.GetEntry("DogeCoinFlag-1.01/GameData/DogeCoinFlag/Flags/dogecoin.png");
+            string tmpfile = Path.GetTempFileName();
+
+            CKAN.ModuleInstaller.CopyZipEntry(zipfile, entry, tmpfile, false);
+
+            long size = new System.IO.FileInfo(tmpfile).Length;
+
+            try
+            {
+                // Compare recorded length against what we expect.
+                Assert.AreEqual(52043, size);
+            }
+            finally
+            {
+                // Tidy up.
+                File.Delete(tmpfile);
+            }
+        }
+
         private void TestDogeCoinStanza(ModuleInstallDescriptor stanza)
         {
             Assert.AreEqual("GameData", stanza.install_to);