Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix travis failing in third-party failures #1782

Merged
merged 2 commits into from
Jun 19, 2016
Merged

Conversation

pjf
Copy link
Member

@pjf pjf commented Jun 19, 2016

These changes:

  • Say it's okay for mozroots to fail.
  • Avoid hitting github for something they might decline.

The test for these is that travis tests are now passing again, which I need them to do before I can make a release. :)

pjf added 2 commits June 19, 2016 20:48
Although if it's okay to fail, we probably don't need to run it at all.
This hits github, and github gets grumpy when travel hits it too often,
resulting in a false failure when we get denied rather than our expected
kraken.
@techman83
Copy link
Member

Awesome! Passing tests are the best!

@techman83 techman83 merged commit d904589 into master Jun 19, 2016
@techman83 techman83 deleted the travis_please_get_better branch June 19, 2016 11:23
pjf added a commit that referenced this pull request Jun 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants