Fix exception installing some mods (fixes #2135) #2137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Path.GetDirectoryName("/a/b/c") returns "\a\b" on windows, but the
regexp assumes forward slashes.
On Linux it returns "/a/b", so the problem is platform-specific.
Olympic1
approved these changes
Oct 14, 2017
|
@Olympic1 , so should I merge this myself? I'm not sure how "approved these changes" fits into CKAN's typical work flow. Thanks for taking a look! |
|
Oh, I thought I pressed the merge button. Was looking on my phone. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Path.GetDirectoryName("/a/b/c")returns"\a\b"on windows, but the regexp assumes forward slashes.On Linux it returns "/a/b", so the problem is platform-specific.
Since the regexp didn't match on Windows, the loop would fail to find the path and raise a file not found exception, as reported in #2135. I believe only
find-based netkans were affected, but unfortunately that includesDefaultInstallStanza.Renormalizing back to forward slashes ensures the regexp will match as it should.