Fix crash on startup (fixes #2134) #2138
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a mod isn't in the registry, return null instead of raising an exception when looking for its max KSP version
Olympic1
approved these changes
Oct 14, 2017
|
@HebaruSan & @Olympic1, can I just point you to https://github.com/KSP-CKAN/CKAN/wiki/Releasing-a-new-CKAN-client which has some points regarding merging PRs to the codebase? We really want to keep the Changelog up to date. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a mod isn't in the registry, return null instead of raising an exception when looking for its max KSP version
When I tested this code change, I had a very recent registry, so the code only ran with identifiers that were in the dictionary. Users updating to 1.22.4 encountered newly added mods, which caused an exception as reported in #2134. Checking
ContainsKeyfirst will avoid this, and returningnullsignals that the mod is not in the registry, which will cause the column to default to max version of the newly added mod object.