Add skip_deploy to GitHub release deploy provider

[dbent]

Potential fix for #2133

The failure in #2133 has nothing to do with our build process, but is a Ruby error generated by Travis itself:

No such file or directory @ rb_sysopen - _build/repack/Release/ckan.exe

Meaning it can't find the file to deploy. The skip_deploy option is necessary to prevent Travis from cleaning out the working directory according to this. The GitHub release provider did not have yet, although the Amazon S3 provider did. My assumption is that previously any provider having skip_cleanup meant that no cleanup was done and that some change was made in Travis which causes cleanup to be done if any provider doesn't have it. Only way to really test this is to try another release @politas

[politas]

I guess we could test by pushing a prerelease? I expect that the auto-updater should ignore those.

[politas]

The entire virtual machine created to process the release gets deleted after the deployment is finished, doesn't it?

[politas]

Oh, wow. The "latest netkan.exe" on S3 is v1.23.0! This has been messed up for some time!

[politas]

@techman83, can you weigh in on whether setting that skip_deploy to true will fix the deploy to S3? I guess if we merge this, that will in effect test the proposition because this will be the version of travis.yml used for the merge-triggered deployment to Amazon?

[dbent]

I guess we could test by pushing a prerelease? I expect that the auto-updater should ignore those.

Probably?

The entire virtual machine created to process the release gets deleted after the deployment is finished, doesn't it?

Yes.

Oh, wow. The "latest netkan.exe" on S3 is v1.23.0! This has been messed up for some time!

Isn't that correct? The version in the changelog is currently v1.23.0-PRE.

[politas]

Isn't that correct? The version in the changelog is currently v1.23.0-PRE.

Oh, yes, of course. I was comparing the 3 at the end of v1.23 to the 6 in v.1.22.6!

[politas]

Well, no testing using a pre-release, unfortunately https://travis-ci.org/KSP-CKAN/CKAN/jobs/289332674

Skipping a deployment with the releases provider because this is not a tagged commit

[politas]

Ok, maybe that was the wrong build report.

[politas]

https://travis-ci.org/KSP-CKAN/CKAN/jobs/289333860 deployed correctly! Great work, @dbent!

[techman83]

Well done @politas / @dbent !