Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open ZIP button, instance name in status bar, description scroll bar #2813

Merged
merged 1 commit into from
Jun 27, 2019

Conversation

HebaruSan
Copy link
Member

@HebaruSan HebaruSan commented Jun 26, 2019

This pull request satisfies three minor GUI requests that came in recently.

Description scroll bar

Now if a module has a description (most don't), it will have a vertical scroll bar in case it's longer than the available space:

image

image

Fixes #2795.

Instance name in status bar

Now the status bar will show the game instance name and version:

image

German translation: Spielinstanz: whatever (KSP whatever)

Fixes #2807.

Open ZIP button on Contents tab of mod info

Now the Download button has an Open ZIP button next to it:

image

It becomes enabled when the module is cached:

image

Clicking it opens the ZIP file from the cache in your OS's archive browser (in this screenshot, whatever GNOME Shell uses):

image

German translation: ZIP öffnen

Fixes #2800.

@HebaruSan HebaruSan added Enhancement Easy This is easy to fix GUI Issues affecting the interactive GUI Pull request labels Jun 26, 2019
@DasSkelett
Copy link
Member

Now if a module has a description (most don't), it will have a vertical scroll bar in case it's longer than the available space:

It appears they always have scrollbars, even if the description is short enough to fit in the available space:

scrollbar

For the German translations, take ZIP öffnen (switch around) for the button,
and Spielinstanz: [...] (without space, and an 's' is missing).

@HebaruSan
Copy link
Member Author

It appears they always have scrollbars, even if the description is short enough to fit in the available space:

Yeah, TextBox doesn't have a ScrollBars=Auto mode.

@HebaruSan HebaruSan force-pushed the feature/three-small-gui-tweaks branch from 0605290 to a9e887d Compare June 27, 2019 15:50
@HebaruSan HebaruSan merged commit a9e887d into KSP-CKAN:master Jun 27, 2019
HebaruSan added a commit that referenced this pull request Jun 27, 2019
@HebaruSan HebaruSan deleted the feature/three-small-gui-tweaks branch August 28, 2019 18:56
@DasSkelett DasSkelett added the i18n Issues regarding the internationalization of CKAN and PRs that need translating label Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Easy This is easy to fix Enhancement GUI Issues affecting the interactive GUI i18n Issues regarding the internationalization of CKAN and PRs that need translating Pull request
Projects
None yet
2 participants