Satisfy dependencies with installed incompatible modules #3137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
If you force-install an incompatible module (with no compatible versions), then try to install a mod with a recommendation that depends on it, you get this in the recommendations screen:
If you try to install a mod that depends on the depending mod, without the recommendations step:
Somehow if you simply install a mod that depends on the manually installed mod, that works fine. No idea why,
RelationshipResolver
is magic. 🌠Cause
RelationshipResolver.MightBeInstallable
, which is used as the first-pass basic installability checker, only looks at compatible available modules to satisfy dependencies. It doesn't check installed modules at all.Changes
Now dependencies that are satisfied by an installed module will be treated as satisfied.
The
DependencyNotSatisfiedKraken
also has some more informative default reason messages.Fixes #3134.