-
Notifications
You must be signed in to change notification settings - Fork 953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vowpal Wabbit failing import #135
Comments
Thanks for flagging this. Looks like Vowpal Wabbit's build process is quite complex, and the patches we used for Python 3.4 haven't carried across to Python 3.6. I'm going to have to keep working on this. |
Was there a progress on VW integration? In the kernels on kaggle one gets: import vowpalwabbit
---------------------------------------------------------------------------
ModuleNotFoundError Traceback (most recent call last)
<ipython-input-2-ea6142880cc4> in <module>()
----> 1 import vowpalwabbit
ModuleNotFoundError: No module named 'vowpalwabbit' |
@mlisovyi The last time I tried getting vowpal wabbit working was unsuccessful. I don't remember why so I'll put it on my to do list to try again. |
@crawforc3 Thanks a lot! this will be very helpful as vowpalwabbit is a handy tool and a kernel with nice intro will be helpful for beginners. The python binding of VW would be sufficient. |
Ok, i managed to install relevant packages and VW in the docker image locally. This requires a few small updates to the VW Makefiles and there is already a relevant VW PR. I will wait for that to be merged (fingers crossed) and will add a PR request here. |
No particular policy at this time. You're probably the first who wonders about that. I believe that, so long it produces ABI compatible objects it interfaces with, it should be fine. If that isn't the case, I would expect you to notice issues with that in build failures or at runtime (make sure to run the tests!). Some issues sometimes sneak through this process and we will roll back the culprit changes accordingly, reintroducing them (with increased test coverage) with a fix, when/if a fix is found. |
Thanks for the prompt feedback. Could you point me at the instructions on the tests required? This is my first experience with docker. The main README.md does not mention anything. |
Hi @mlisovyi, we have some rudimentary tests in test_build.py. At a bare minimum, that script should run successfully. |
I also just updated the README.md with the build / test instructions. Thanks for letting me know if that covers it and works for you. |
The required PR in vowpal wabbit has been merged. Now i'm trying to add it o the kaggle docker file. @sebbov are there a simplified procedure? Or practical suggestions on how to speed up building. I was running the |
Just added the first VW kernel on the Titanic dataset, and it runs smooth: https://www.kaggle.com/mlisovyi/vowpal-wabbit-decides-who-lives-and-who-dies. I guess, this issue can be closed now |
Awesome :) Closing this now but let us know if you run into any problems |
@mlisovyi Re-opening because I am no longer able to install VW in our docker images. I think it may be related to VowpalWabbit/vowpal_wabbit@a300157 |
@crawforc3 Can you share a log? Indeed, it was never checked in kaggle kernels, but vw developers claimed that it was checked in a docker image in some setup |
@crawforc3 is there a way to check it without download and built of the WHOLE image? It is way too large by now. I changed laptop and now would have to install everything from scratch, which is very demotivating, to be honest |
I had to pin the previous version for it to work. Closing this for now. |
The text was updated successfully, but these errors were encountered: