Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Repro] Consume published libraries #106

Closed

Conversation

sebastienrouif
Copy link
Contributor

used published libraries so show that visibility of function has changed

@@ -23,6 +23,8 @@ junitVersion = "4.13.2"
junitExtVersion = "1.1.5"
multidexVersion = "2.0.1"
materialVersion = "1.10.0"
kakaoversion = "3.4.1"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changing to 3.5.0 fails build

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good day, thanks for the reporting about the issue. Hm, that is quite strange, because we migrated from 3.4.1 to 3.5.0 without any issues. And we have more than 1.3k UI tests.

As well, could you provide any information about which methods visibility has been affected?

Unfortunately I'm on vacation and will be back at the end of December

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there! I just checked the getResourceDwarable() function that you imported into the PR, and it's signature hasn't changed since the last 3 years. Could you please add more details on to what exactly has changed it's visibility?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, the signature hasn't changed, totally agree with that.
However, if you checkout this branch which consumes the released library you'll realise that the function is visible in 3.4.1 but not in 3.5.0.
I checked the source of the published library and I see the function. I'm not sure what's going on in terms of visibility
Screenshot 2023-12-11 at 09 44 24

Screenshot 2023-12-11 at 09 44 37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants