-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Repro] Consume published libraries #106
Closed
sebastienrouif
wants to merge
1
commit into
KakaoCup:master
from
sebastienrouif:bug/function_visibility
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changing to 3.5.0 fails build
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good day, thanks for the reporting about the issue. Hm, that is quite strange, because we migrated from 3.4.1 to 3.5.0 without any issues. And we have more than 1.3k UI tests.
As well, could you provide any information about which methods visibility has been affected?
Unfortunately I'm on vacation and will be back at the end of December
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey there! I just checked the
getResourceDwarable()
function that you imported into the PR, and it's signature hasn't changed since the last 3 years. Could you please add more details on to what exactly has changed it's visibility?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, the signature hasn't changed, totally agree with that.
![Screenshot 2023-12-11 at 09 44 24](https://private-user-images.githubusercontent.com/2768618/289506009-1f4c3f04-55cd-45b1-9c2f-cff7e1afe371.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjQ5NjMzMjMsIm5iZiI6MTcyNDk2MzAyMywicGF0aCI6Ii8yNzY4NjE4LzI4OTUwNjAwOS0xZjRjM2YwNC01NWNkLTQ1YjEtOWMyZi1jZmY3ZTFhZmUzNzEucG5nP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI0MDgyOSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNDA4MjlUMjAyMzQzWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9NGQ3YzBmYThiOTNlYmQ2OTY0NGQzZjAzNTFhYjU2MjAxZjkzMWJjYzcyMzUzZDE5ZTNlMTAwYzRjMTI5MzA2NSZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QmYWN0b3JfaWQ9MCZrZXlfaWQ9MCZyZXBvX2lkPTAifQ.UoN-JfMmtF9rN-IeT01DANXTnIroPJoHizowzTcHMQw)
However, if you checkout this branch which consumes the released library you'll realise that the function is visible in
3.4.1
but not in3.5.0
.I checked the source of the published library and I see the function. I'm not sure what's going on in terms of visibility