Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Login feedback for users #16

Merged
merged 5 commits into from
Aug 7, 2022
Merged

Login feedback for users #16

merged 5 commits into from
Aug 7, 2022

Conversation

suzanpradhan
Copy link

Logging in

  • ✅incorrect password
  • ✅incorrect email
  • ✅email/account doesn't exist

Signing up

  • ✅email already exists
  • ✅passwords don't match
  • ✅password is too short

@suzanpradhan suzanpradhan changed the title Login feedback for users #15 Login feedback for users Aug 6, 2022
@suzanpradhan suzanpradhan changed the title #15 Login feedback for users Login feedback for users Aug 6, 2022
@Scount
Copy link

Scount commented Aug 6, 2022

All use cases tested and were correct.
I have only one thing. Validations are core features and will be used for different things. Therefore please move the validation folder into the core folder.

@suzanpradhan suzanpradhan reopened this Aug 6, 2022
@suzanpradhan
Copy link
Author

LoginPage and LoginData are now renamed to AuthenticationPage and AuthData.

@KalleHallden KalleHallden merged commit 8d853bf into EXERLOG:Login Aug 7, 2022
@Scount Scount mentioned this pull request Aug 7, 2022
Closed
@mfederowicz mfederowicz mentioned this pull request Aug 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@suzanpradhan @Scount @KalleHallden