Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor visual-insights #17

Merged
merged 6 commits into from Jan 19, 2020
Merged

refactor visual-insights #17

merged 6 commits into from Jan 19, 2020

Conversation

ObservedObserver
Copy link
Member

No description provided.

@todo
Copy link

todo bot commented Jan 19, 2020

delete this file, fieldsAnalysis is an old api.

* todo: delete this file, fieldsAnalysis is an old api.
*/
import { DataSource, Field, FieldImpurity } from './commonTypes'
import {


This comment was generated by todo based on a todo comment in 4138df1 in #17. cc @Kanaries.

@todo
Copy link

todo bot commented Jan 19, 2020

delete kruskal with limit size, use largest size to limit it(uncontrolled group number but better), need discuss.

// todo: delete kruskal with limit size, use largest size to limit it(uncontrolled group number but better), need discuss.
/**
*
* @param matrix


This comment was generated by todo based on a todo comment in 4138df1 in #17. cc @Kanaries.

@todo
Copy link

todo bot commented Jan 19, 2020

(P1):

// todo (P1):
// don't use dimScores: FieldImpurity.
// it's a structure with redundency design.
function specification (dimScores: FieldImpurity[], aggData: DataSource, dimensions: string[], measures: string[]): View {


This comment was generated by todo based on a todo comment in 4138df1 in #17. cc @Kanaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant