Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date picker does not work in Streamlit #256

Closed
ilyanoskov opened this issue Oct 5, 2023 · 14 comments
Closed

Date picker does not work in Streamlit #256

ilyanoskov opened this issue Oct 5, 2023 · 14 comments
Labels
bug Something isn't working graphic-walker belong to Graphic Walker project

Comments

@ilyanoskov
Copy link

I am using Pygwalker with Streamlit and it appears that the date picker does not work both with DuckDB and regular format. Can you please confirm it's working?

@longxiaofei
Copy link
Contributor

Which the version of pygwalker are you using?

What is the type of your date field?

If it is a string, What is the format of your date field?

@ilyanoskov
Copy link
Author

Which the version of pygwalker are you using?

What is the type of your date field?

If it is a string, What is the format of your date field?

I am using the latest 0.3.8a2 version that is available on Conda.

The type is pd.to_datetime

I also tried passing parse_dates parameter but that did not change anything

@longxiaofei
Copy link
Contributor

longxiaofei commented Oct 5, 2023

I'm trying to reproduce it.

date picker is working, but there are some time zone bugs.

What is the status with date picker in your dataset?

@ilyanoskov
Copy link
Author

I'm trying to reproduce it.

date picker is working, but there are some time zone bugs.

What is the status with date picker in your dataset?

I am using the UTC timezone, so no timezone issues, however I have a dataset with mixed dates (not continuous dates) and able to select only one month, while the dataset contains different months

@ilyanoskov
Copy link
Author

With DuckDB I am not able to select any dates and the date picker shows selector for the year 1970

@longxiaofei
Copy link
Contributor

Can you give me some sample data?

df[["your_date_field"]][:1000].to_pickle("example.pkl")

It's already 1:00 am here, I will reply to you tomorrow.

@ObservedObserver ObservedObserver added bug Something isn't working graphic-walker belong to Graphic Walker project labels Oct 6, 2023
@ObservedObserver
Copy link
Member

ObservedObserver commented Oct 6, 2023

It's a bug in graphic-walker which can be reproduced with any dataset with temporal field in graphic walker online playground

@ilyanoskov
Copy link
Author

Hi @ObservedObserver @longxiaofei @Asm-Def, it appears that the above issue has been fixed? Can you please cut a release for it on Conda so users can start using the date picker again? Thank you very much in advance

@longxiaofei
Copy link
Contributor

@ilyanoskov Hi, I discovered another date picker bug during pre-release testing today.

I will release a new version before Oct. 18 after fixing this bug.

@longxiaofei
Copy link
Contributor

@ilyanoskov 0.3.8 version already released in conda, But I'm not sure whether to fix this bug(There are too many bugs about date..), looking forward to your feedback.

I only recently noticed this PR:: conda-forge/pygwalker-feedstock#13. Do you need me to add you to CODEOWNERS?

@ilyanoskov
Copy link
Author

Hi, I have checked out the 0.3.9 version and it seems like it still has date picker bugs in Streamlit. Now, the date ranges are not possible to be selected at all.

This makes Pygwalker not usable for even simple data analysis tasks :(

@ilyanoskov
Copy link
Author

Correction, the date picker without DuckDB seems to work, but not with DuckDB

@longxiaofei
Copy link
Contributor

What is the version of duckdb?

This is a demo(base pygwalker0.3.9, use duckdb): https://pygwalker-in-app-twitter-explore.streamlit.app/

everything looks fine.

@longxiaofei
Copy link
Contributor

Can you give me some sample data?

I only need the data for date column.

df[["your_date_field"]][:1000]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working graphic-walker belong to Graphic Walker project
Projects
None yet
Development

No branches or pull requests

3 participants