Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable state restoration #18

Merged
merged 5 commits into from Nov 25, 2016
Merged

Conversation

zhongwuzw
Copy link
Contributor

enable state restoration

enable state restoration
@Kapeli
Copy link
Owner

Kapeli commented Nov 22, 2016

Looks good. One issue: the webView's page gets reverted back to the "This page intentionally left blank" page upon restore.

fix webView issue
@zhongwuzw
Copy link
Contributor Author

@Kapeli , I fix the webView issue.

fix webView url is http/https restoration
@Kapeli
Copy link
Owner

Kapeli commented Nov 23, 2016

More issues on iPad:

  1. Have Settings > Download Docsets open and quit and restore state, the download docsets view on the right isn't restored
  2. If you have the split view collapsed (i.e. webView on whole screen) and quit and restore state, the split view is correctly restored, but the collapse button isn't restored in its right state so it tries to collapse the split view when you first tap it
    2.1. For some reason restoring with the split view collapsed causes the table views to appear below the search field
  3. The selected row of table views isn't restored

enable-state-restore
@zhongwuzw
Copy link
Contributor Author

@Kapeli I fixed issues on iPad. for the second issue, I think it's UISearchDisplayController bugs, so my solution is to force non-collapsed when state restoration.

@Kapeli
Copy link
Owner

Kapeli commented Nov 24, 2016

More issues:

  1. Doesn't work with Remotes
  2. Issue 1 from enable state restoration #18 (comment) is still present on iPhone 6/7 Plus in landscape mode

add remoteBrowser state restoration
fix iPhone6/7 Plus download interface restore issue
@zhongwuzw
Copy link
Contributor Author

@Kapeli , I updated codes to fix the issue.

@Kapeli Kapeli merged commit 5b7c283 into Kapeli:master Nov 25, 2016
@Kapeli
Copy link
Owner

Kapeli commented Nov 25, 2016

Awesome job. Thank you! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants