enable state restoration #18

Merged
merged 5 commits into from Nov 25, 2016

Projects

None yet

2 participants

@zhongwuzw
Contributor

enable state restoration

@zhongwuzw zhongwuzw enable state restoration
enable state restoration
5571095
@Kapeli
Owner
Kapeli commented Nov 22, 2016

Looks good. One issue: the webView's page gets reverted back to the "This page intentionally left blank" page upon restore.

@zhongwuzw zhongwuzw fix webView issue
fix webView issue
fd18d51
@zhongwuzw
Contributor

@Kapeli , I fix the webView issue.

@zhongwuzw zhongwuzw fix webView url is http/https restoration
fix webView url is http/https restoration
8de6354
@Kapeli
Owner
Kapeli commented Nov 23, 2016

More issues on iPad:

  1. Have Settings > Download Docsets open and quit and restore state, the download docsets view on the right isn't restored
  2. If you have the split view collapsed (i.e. webView on whole screen) and quit and restore state, the split view is correctly restored, but the collapse button isn't restored in its right state so it tries to collapse the split view when you first tap it
    2.1. For some reason restoring with the split view collapsed causes the table views to appear below the search field
  3. The selected row of table views isn't restored
@zhongwuzw zhongwuzw enable-state-restore
enable-state-restore
b979753
@zhongwuzw
Contributor

@Kapeli I fixed issues on iPad. for the second issue, I think it's UISearchDisplayController bugs, so my solution is to force non-collapsed when state restoration.

@Kapeli
Owner
Kapeli commented Nov 24, 2016

More issues:

  1. Doesn't work with Remotes
  2. Issue 1 from #18 (comment) is still present on iPhone 6/7 Plus in landscape mode
@zhongwuzw zhongwuzw enable-state-restore
add remoteBrowser state restoration
fix iPhone6/7 Plus download interface restore issue
cee975f
@zhongwuzw
Contributor

@Kapeli , I updated codes to fix the issue.

@Kapeli Kapeli merged commit 5b7c283 into Kapeli:master Nov 25, 2016
@Kapeli
Owner
Kapeli commented Nov 25, 2016

Awesome job. Thank you! ๐Ÿ‘

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment