Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update banner of games #117

Closed
BanCrash opened this issue May 6, 2018 · 4 comments
Closed

Update banner of games #117

BanCrash opened this issue May 6, 2018 · 4 comments

Comments

@BanCrash
Copy link
Contributor

BanCrash commented May 6, 2018

Hello again! I have a new suggestion. I was thinking of have the option "update banner" in Game.ini. There are games that changes its banner on certain circunstances (for example, when releasing new content, or exiting Early Access program), and could be useful have the option to update their banner without manually removing the existing banner.

Beside, I want to know if you changed your mind about "completed" option for games, or will be added in a future release.

@Kapiainen
Copy link
Owner

Kapiainen commented May 8, 2018

I'll take it into consideration for version 3.1.0. The solution would have to be platform-dependent. For Steam games you can generate the URL to the banner based on a base/template URL and the game's AppID (can be extracted from the banner path), but for e.g. GOG Galaxy you would either have to re-acquire the URL from the database or always store it in games.json. I'd rather avoid putting a bunch of extra information, which is going to be irrelevant most of the time, into games.json.

At the moment you can click on the banner in Game.ini to open the image in the default program for that file format and at least with Windows Photo Viewer you can delete the banner without going to the folder containing the banner. You would then have to refresh the skin to download the new banner.

At the moment I think that the completed status of a game should be handled by the user via the existing tag system.

@Kapiainen Kapiainen mentioned this issue May 8, 2018
@BanCrash
Copy link
Contributor Author

BanCrash commented May 8, 2018

Perfect, thanks you!!

@Kapiainen
Copy link
Owner

This has now been implemented in the branch for version 3.1.0. The option is available for Steam and GOG Galaxy games.

@BanCrash
Copy link
Contributor Author

I just tried with a steam game and works perfect! Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants