Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

protein tests #182

Merged
merged 20 commits into from Feb 25, 2020
Merged

protein tests #182

merged 20 commits into from Feb 25, 2020

Conversation

yosefdroth
Copy link
Contributor

No description provided.

@coveralls
Copy link

coveralls commented Feb 20, 2020

Pull Request Test Coverage Report for Build 836

  • 67 of 68 (98.53%) changed or added relevant lines in 4 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 91.521%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/scenes/BiochemicalEntityDetails/Rna/MetadataSection.js 8 9 88.89%
Files with Coverage Reduction New Missed Lines %
src/components/SearchForm/SearchForm.js 1 95.71%
Totals Coverage Status
Change from base Build 831: 0.2%
Covered Lines: 1125
Relevant Lines: 1186

💛 - Coveralls

@jonrkarr
Copy link
Member

The branch is not ready for merging. The metabolite tests are failing, at least in part because the importing of the fixture has been deleted.

Todo

  • Fix the failing tests
  • Expand coverage. As necessary, use additional fixtures. Examples:
    • Rna/MetadataSection.js: formatMetadata, formatMetadataInner
    • Protein/MetadataSection.js: formatMetadataInner`
    • Reaction/MetadataSection.js: formatMetadataInner
  • Remove commented out examples in tests such as below to remove potential sources of confusion
    //expect(formattedData[7].source).toEqual({
    //  source: "ymdb",
    //  id: "ymdb_id_xxx"
    //});
    
  • Merge the branch with master and fix additional failures with the RNA and reaction tests

@yosefdroth yosefdroth merged commit b9317bd into master Feb 25, 2020
@jonrkarr jonrkarr mentioned this pull request Feb 25, 2020
@jonrkarr jonrkarr deleted the yosef_dev branch April 14, 2020 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants