Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close #KLI-82 キャリブレーションクラスを実装する #17

Merged
merged 6 commits into from
Jun 26, 2024

Conversation

takahashitom
Copy link
Collaborator

@takahashitom takahashitom commented Jun 19, 2024

チェックリスト

  • clang-format している
  • コーディング規約に準じている
  • チケットの完了条件を満たしている

変更点

キャリブレーションからスタートまでを担当するクラスを定義したソースファイルを module に追加

  • Calibrator.h
  • Calibrator.cpp

Calibratorクラスのテストファイルを test に追加

  • CalibratorTest.cpp

test/dummy/ev3api_button.cpp にボタンの状態を更新する処理を追加

動作テスト

実機を用いて動作確認を行った。

実験結果

https://www.notion.so/uom-katlab/921c76e498ae46ffb460ac98ca8db8f8?pvs=4#26cc69814d694a078263772334aeb998

添付資料

Copy link

@takahashitom takahashitom marked this pull request as ready for review June 23, 2024 05:20
@takahashitom takahashitom self-assigned this Jun 23, 2024
Copy link
Collaborator

@CHIHAYATAKU CHIHAYATAKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

本当に細かいですが,よろしくお願いします.

module/Calibrator.h Outdated Show resolved Hide resolved
Copy link
Collaborator

@CHIHAYATAKU CHIHAYATAKU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

僕は問題ないと思います
LGTM

Copy link
Collaborator

@aridome222 aridome222 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@bizyutyu bizyutyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OKだと思います。LGTM!
LGTM

Copy link

@negiuniv negiuniv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

getIsLeftCourseにちょっと思ったけどロボコンの命名規則ならあってるわ
LGTM

@YKhm20020 YKhm20020 merged commit cb28c2f into main Jun 26, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants