-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
close #KLI-82 キャリブレーションクラスを実装する #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
本当に細かいですが,よろしくお願いします.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
getIsLeftCourseにちょっと思ったけどロボコンの命名規則ならあってるわ
LGTM
チェックリスト
変更点
キャリブレーションからスタートまでを担当するクラスを定義したソースファイルを module に追加
Calibratorクラスのテストファイルを test に追加
test/dummy/ev3api_button.cpp にボタンの状態を更新する処理を追加
動作テスト
実機を用いて動作確認を行った。
実験結果
https://www.notion.so/uom-katlab/921c76e498ae46ffb460ac98ca8db8f8?pvs=4#26cc69814d694a078263772334aeb998
添付資料