Move devel installation to playbook and role

[ehelms]

No description provided.

[ekohl]

Why do you only do this for centos7-devel and not centos6-devel?

[stbenjam]

CentOS 6 is dead for foreman nightly. Even if it's resurrected, maybe it's time to drop el6 as a dev box option anyway?

[ehelms]

See #281 for removal

[ehelms]

This has been rebased

[stbenjam]

How about adding this?

   variables:
       katello_devel_username: stbenjam

And removing it from the playbook

[stbenjam]

Also maybe more obvious with github in the variable name, to match the installer flag

[stbenjam]

Needs --disable-system-checks

[ehelms]

Updated

[stbenjam]

Looks ok, building a box now

[stbenjam]

@ehelms

TASK [katello_devel : Run devel installer] *************************************
Thursday 13 October 2016  13:59:28 -0400 (0:01:14.356)       0:12:04.932 ****** 
fatal: [ansible-devel]: FAILED! => {"failed": true, "msg": "The conditional check 'skip_installer == False' failed. The error was: error while evaluating conditional (skip_installer == False): 'skip_installer' is undefined\n\nThe error appears to have been in '/home/stbenjam/git/forklift/playbooks/roles/katello_devel/tasks/main.yml': line 12, column 3, but may\nbe elsewhere in the file depending on the exact syntax problem.\n\nThe offending line appears to be:\n\n\n- name: 'Run devel installer'\n  ^ here\n"}

I think you can gate the check with skip_installer is defined && ...

[ekohl]

I think puppet_repositories could be a useful addition as well, allowing users to install puppet 4.

[thomasmckay]

Need these two:

• • epel_repositories
• • puppet_repositories

[thomasmckay]

I don't know if it's applicable here or should just be a RTFM action but not being able to just pop into ~/foreman and run bin/rails s -b 0.0.0.0 (or whatever the foreman command is) is not ideal. I had to yum install npm, npm install, rake webpack:compile. I could not hit the server at https only http:3000.

Also, I think only the katello dir had my remote added? Should be added to foreman too.

Maybe echo out "go here for finishing instructions for running a development server".

[ekohl]

I think that's something that was also lacking with setup.rb and something that needs to be added to puppet-katello_devel

[ehelms]

@ekohl @thomasmckay @stbenjam updates made across the board from comments

[thomasmckay]

ack

[ehelms]

@stbenjam please have a look when you get a chance

[stbenjam]

From an ansible perspective it seems to be fine, as it does everything up to and including running the devel installer, although the install itself fails but that's happening with the old dev setup too I guess:

[ WARN 2016-11-10 10:13:15 verbose]  /Stage[main]/Katello_devel::Setup/Exec[rails server]/returns: => Run `rails server -h` for more startup options
[ WARN 2016-11-10 10:13:15 verbose]  /Stage[main]/Katello_devel::Setup/Exec[rails server]/returns: A server is already running. Check /home/vagrant/foreman/tmp/pids/server.pid.
[ERROR 2016-11-10 10:13:15 verbose]  /Stage[main]/Katello_devel::Setup/Exec[rails server]: Failed to call refresh: sudo su vagrant -c '/bin/bash --login -c "rvm use 2.2.4 && bundle exec rails s -d"' returned 1 instead of one of [0]
[ERROR 2016-11-10 10:13:15 verbose]  /Stage[main]/Katello_devel::Setup/Exec[rails server]: sudo su vagrant -c '/bin/bash --login -c "rvm use 2.2.4 && bundle exec rails s -d"' returned 1 instead of one of [0]
[ERROR 2016-11-10 10:13:15 verbose] /usr/share/ruby/vendor_ruby/puppet/util/errors.rb:106:in `fail'
[ERROR 2016-11-10 10:13:15 verbose] /usr/share/ruby/vendor_ruby/puppet/type/exec.rb:160:in `sync'
[ERROR 2016-11-10 10:13:15 verbose] /usr/share/ruby/vendor_ruby/puppet/type/exec.rb:583:in `refresh'