Fixes #36122 - Hide unsyncable content type warning #10456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
until the information is actually loaded
|
Issues: #36122 |
ianballou
approved these changes
Feb 21, 2023
lfu
pushed a commit
to lfu/katello
that referenced
this pull request
Mar 2, 2023
until the information is actually loaded (cherry picked from commit 35fcf95)
lfu
pushed a commit
that referenced
this pull request
Mar 29, 2023
until the information is actually loaded (cherry picked from commit 35fcf95)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
until the information is actually loaded
What are the changes introduced in this pull request?
The warning is supposed to be based on some data, but the condition was failing if the data was not loaded yet. These changes take that option into consideration.
Considerations taken when implementing this change?
Carrying some default state in the angular controller would probably be cleaner, but this seems to work
What are the testing steps for this pull request?