Fixes #36278 - Use hostgroup os refresh path in hostgroup edit #10505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the code path taken to update OS when one of the katello fields was changed was determined based on presence of dom element matching #hostgroup_parent_id. However, this element was only present if the user was editing a hostgroup and had more than one hostgroup visible in the current context. The refresh should now get triggered if data-type of element matching #hostgroup_operatingsystem_id is hostgroup which should be a more reliable indicator.
|
Issues: #36278 |
chris1984
approved these changes
Apr 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What are the changes introduced in this pull request?
Previously the code path taken to update OS when one of the katello fields was changed was determined based on presence of dom element matching #hostgroup_parent_id. However, this element was only present if the user was editing a hostgroup and had more than one hostgroup visible in the current context.
The refresh should now get triggered if data-type of element matching #hostgroup_operatingsystem_id is hostgroup which should be a more reliable indicator.
What are the testing steps for this pull request?
You should see a request being done to /hostgroups/os_selected.
Without this patch, this should only happen if you have multiple hostgroups.