Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #36445 - remove extra th element from repository sets page #10575

Merged
merged 2 commits into from
May 26, 2023
Merged

Fixes #36445 - remove extra th element from repository sets page #10575

merged 2 commits into from
May 26, 2023

Conversation

trev-allison03
Copy link
Contributor

What are the changes introduced in this pull request?

Removing the extra th element from the repository sets page

Considerations taken when implementing this change?

What are the testing steps for this pull request?

Steps to Reproduce:

  1. Register host
  2. Navigate to All hosts->$hostname->Content->Repository sets
  3. Check DOM for the table, the number of header columns should be the same as the number of columns in rows

@theforeman-bot
Copy link

Can one of the admins verify this patch?

@theforeman-bot
Copy link

Issues: #36445

@jeremylenz
Copy link
Member

[test katello]

@jeremylenz
Copy link
Member

@trev-allison03 Looks like eslint failed. npx eslint webpack/ --fix should fix it :)

jeremylenz
jeremylenz approved these changes May 26, 2023
View reviewed changes
Copy link
Member

@jeremylenz jeremylenz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra <td> element is removed as advertised.

APJ 👍

@jeremylenz
Copy link
Member

[test katello]

@jeremylenz jeremylenz merged commit 1a75835 into Katello:master May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremylenz jeremylenz jeremylenz approved these changes

Assignees
No one assigned
Labels
Not yet reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@trev-allison03 @theforeman-bot @jeremylenz