Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #36712 - Add true select all to errata legacy UI #10715

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chris1984
Copy link
Member

What are the changes introduced in this pull request?

  • Adding a select all option in the errata legacy UI when you start to select errata on the table

prerrata

Considerations taken when implementing this change?

  • It looks like Bastion does not keep track of records selected when switching pages in the pagination on multiple pages so this is as close to fixing it as I can. I can raise a Redmine issue to try and fix the other areas, but outside of the scope of this PR

What are the testing steps for this pull request?

  • Sync some repos that have errata in them
  • Goto content - Errata and select a few and see if the new select all works
  • Change the tab to the next table page and make sure they are all selected still
  • Click apply and see if it takes you to the next screen without an error

@theforeman-bot
Copy link

Issues: #36712

Copy link

@Ron-Lavi Ron-Lavi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @chris1984, can you rebase?

@chris1984
Copy link
Member Author

@Ron-Lavi this approach does not work, Jeremy tested it a while ago. It's not sending the params correctly when you get to the last page, so I gave up on it hence why it's so old.

@chris1984
Copy link
Member Author

I thought it would be an easy fix but it turned out to not be as easy as I thought it would be. With us getting rid of the old UI eventually, should we even bother to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants