Pulpcore upgrade #10949
Merged
Pulpcore upgrade #10949
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianballou
approved these changes
Mar 29, 2024
There was a problem hiding this comment.
Looks good! Just need to wait to merge until the packaging PRs (like theforeman/foreman-packaging#10658) are ready.
|
Added teardown code to some of our tests which didn't have those. Also added code path to look up dangling distributions during orphan cleanup and version deletion to resolve this: https://projects.theforeman.org/issues/37314 |
ianballou
reviewed
Apr 3, 2024
| distribution_deletion_tasks = [] | ||
| distro_hrefs = [] | ||
| orphan_repository_versions.each do |api, version_hrefs| | ||
| next if api.repository_type.id == :deb |
There was a problem hiding this comment.
Is there no workaround for Debian?
ianballou
reviewed
Apr 5, 2024
ianballou
approved these changes
Apr 8, 2024
(cherry picked from commit 4b306986bb493e77882b386984abc2850c030463)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related pulpcore upgrade PRs:
theforeman/foreman-packaging#10658
theforeman/pulpcore-packaging#931
theforeman/foreman-packaging#10667
What are the changes introduced in this pull request?
Update pulp bindings and VCRs
Considerations taken when implementing this change?
What are the testing steps for this pull request?
On a box with upgraded pulp packages, check this out and run through some smoke testing.