1011854: Filter: initialize product/repo selector before the filter rules list #3037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ules list This commit moves the initialization of the product and repo selectors to occur before the filter rules list initialization. This is necessary so that we can correctly render the rules pane. E.g. if there are no products selected, we render a warning.
|
ack |
bbuckingham
added a commit
that referenced
this pull request
Sep 25, 2013
1011854: Filter: initialize product/repo selector before the filter rules list
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit moves the initialization of the product and repo selectors
to occur before the filter rules list initialization. This is necessary
so that we can correctly render the rules pane. E.g. if there are
no products selected, we render a warning.