[DO NOT MERGE] Engine: Adding basic Foreman plugin definition. #3446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,3 +1,3 @@ | |||
| Foreman::Application.routes.draw do | |||
| mount Katello::Engine, :at => "/katello" | |||
| mount Katello::Engine, :at => "/katello", :as => 'katello' | |||
There was a problem hiding this comment.
this is OK but not necessary
http://edgeapi.rubyonrails.org/classes/Rails/Engine.html
routes: when you mount an Engine with mount(MyEngine::Engine => '/my_engine'), it's used as default :as option
PR: Request merge of engine branch to master
Katello::Api::V1::UsersControllerTest.test_list_owners_username
API v2 - specify API version via headers or in urls
This "portlet" (aka widget) on the dashboard implements user story "As a dashboard user, I want to see current subscription totals" in SAM backlog sprint 10. This portlet adds the following functionality: - It links to the subscriptions search page, where the results shown are filtered by date range using elasticsearch. - The counts shown are calculated from new methods on the Pool class in the katello app's models. - I add a helper method to the DashboardHelper that permits a portlet or widget to exclude the quantity dropdown from displaying in cases such as this where quantity doesn't make sense.
these files were moved: app/views/api/v2/common/collection_resource.json.rabl --> app/views/katello/api/v2/common/collection_resource.json.rabl app/views/api/v2/common/single_resource.json.rabl --> app/views/katello/api/v2/common/single_resource.json.rabl
also included is optional root-node for single resource responses Conflicts: app/controllers/katello/api/v2/api_controller.rb
Add subscription totals portlet to the dashboard
Engine: Fixes font pathing issues within RCUE library.
updates for v2 API and ping controller
…the core's org This commit contains changes so that the katello organization is now an extension of the core (foreman) organization. The result will be a single organization (taxonomies) schema. Based on discussion with the team, since we are early on with the engine work, we are purposely updating the existing migration to remove 'katello_organizations' vs trying to migrate data from katello_organizations to taxonomies. This means users will need to katello:reset and then db:migrate / db:seed.
…xtensions This commit is to fix the tests that are affected by the changes to the code to support a core organization (foreman) which is extended to support katello properties. Note: the tests leverage the 'taxonomies' fixture from the foreman core to provide a couple of organizations to test with.
change version to 1.5.0 for next release
Engine: Fixing katello_dev gem echo statement
Fixing inconsistency in setup workflow.
API v2 - v2 systems_controller and systems actions
Engine: Renaming katello gemfile to something less generic
This change moves the Example Dependency Errors section above the section Fixing Dependency Errors so that the reader finds the more common errors with their exact fixes before the list of the more generalized error fixes. Other changes include: - Add reference links between the two re-organized sections to facilitate troubleshooting. - Add notes regarding the use of the `grunt bower:update` command as well as when it should be run. - Make section heading text match style of related sections by using appropriate capitalization as well as revising their length to have fewer words. - Fix minor typo
Update README with JavaScript troubleshooting solutions
Creating a katello.local.rb for development
Previously, users had to run "splice-debug" in addition to katello-debug in order to capture enhanced reporting logs related to splice. Instead, check if spacewalk-splice-tool is installed and if it is, capture enhanced reporting logs.
Changes to support Katello engine RPM builds
add enhanced reporting logs to katello-debug
Bastion: remove unused infinite scroll include path from karma config.
remove packages available via rhscl
scope-app - add Katello:: to all ApplicationController
Removing duplicate in_environment scope
This adds the Foreman plugin definition to define a single navigation menu setup when Katello is installed. Overlapping entities are scoped by naming and an entire Content menu is added for the unique entities Katello brings.
|
Closing to re-open against master. |
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the Foreman plugin definition to define a single
navigation menu setup when Katello is installed. Overlapping entities
are scoped by naming and an entire Content menu is added for the
unique entities Katello brings.
This is the initial work to get a single navigation and is by no means the complete work. This relies initially on theforeman/foreman#1071
Further, I would like the approach taken to be review by at least another Katello developer and @abenari and @isratrade.
More updates will follow to get Katello pages showing within the single navigation.