api v2 - systems actions

[komidore64]

• - create
• - index
• - show
• - update
• - destroy
• - tasks
• - add_system_groups
• - remove_system_groups
• - package_profile
• - report
• - errata
• - pools
• - releases
• - activate
• - enabled_repos
• - refresh_subscriptions
• - tests!!
• - squash commits

[thomasmckay]

What do you think about leaving this one out so it isn't in docs nor available through apipie?

[komidore64]

@thomasmckay have the compatibility routes no-doc'd? i'd be cool with that

[komidore64]

removing the rhsm compatibility routes doco in a different PR

[thomasmckay]

Missing param_rules?

[thomasmckay]

Ideally the v1 controller would be empty with all logic in v2.

[komidore64]

@thomasmckay well of course, ideally

[thomasmckay]

I had to edit param_rules to include search params (could be bad merge on my local pull-request branch?)

:index => [:page, :per_page, :sort_order, :sort_by, :paged, :system, :name, :pool_id, :search, :uuid, :organization_id, :environment_id, :system_group_id],

Also got an error on line 332

desc << "A hint for choosing the right value for the releaseVer param"

[daviddavis]

Please squash these commits before you merge so we don't end up with another mess in our git history.

[thomasmckay]

@komidore64

• setup_content_view() missing from v2 controller (need to copy from v1)
• i think :id should be in the update() param_rules, right?
• line 585 is trying to add build something incorrectly

  NoMethodError: undefined method `+' for #<ActiveSupport::HashWithIndifferentAccess:0x007fc94d618c58>

[komidore64]

@thomasmckay

1. oops, will copy and add
2. yes! i did miss it. i've got it fixed locally

[komidore64]

@daviddavis will do

[thomasmckay]

Still missing :paged, :page_size, :page, and :sort. Probably testable in the UI.

[thomasmckay]

ack pending jenkins